Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for python-wheel data directory #1801

Merged
merged 1 commit into from
Mar 21, 2024
Merged

feat: Add support for python-wheel data directory #1801

merged 1 commit into from
Mar 21, 2024

Conversation

BradHolmes
Copy link
Contributor

@BradHolmes BradHolmes commented Mar 12, 2024 •
edited
Loading

Fixes #1777

  • Adds data_files attribute to py_wheel rule.
  • Minimal validation of the data-files target directories per specification
  • Added two tests.
  • Added example

@BradHolmes BradHolmes requested a review from rickeylev as a code owner March 12, 2024 20:24
@google-cla Google CLA
Copy link

google-cla bot commented Mar 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@BradHolmes BradHolmes force-pushed the support-data-files-in-pywheel branch 3 times, most recently from a4d20e5 to 9469321 Compare March 12, 2024 23:56
aignas
aignas reviewed Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be also great to add an example in examples/wheel directory.

I think the implementation is really nice, thank you a lot for submitting this.

tools/wheelmaker.py Outdated Show resolved Hide resolved
@BradHolmes BradHolmes force-pushed the support-data-files-in-pywheel branch 2 times, most recently from 5664bf2 to b7c6da6 Compare March 20, 2024 09:59
@BradHolmes
Copy link
Contributor Author

OK, I think this PR is ready. I updated the code, added a data check, added another test and an example.

@rickeylev, I think this needs your approval.
@aignas, thank you for the helpful feedback and support!

aignas
aignas reviewed Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also review, stamp and merge this :)

examples/wheel/BUILD.bazel Show resolved Hide resolved
@BradHolmes BradHolmes force-pushed the support-data-files-in-pywheel branch from b7c6da6 to 3b5dc2c Compare March 21, 2024 10:56
aignas
aignas reviewed Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment, but looksgood otherwise

python/private/py_wheel.bzl Outdated Show resolved Hide resolved
@BradHolmes
feat(py_wheel): Add support for .data/ files in pywheel
2090a16 
This feature addes  attribute to the py_wheel rule and
makes a related change to the wheelmaker tool.

Fixes bazelbuild#1777
@BradHolmes BradHolmes force-pushed the support-data-files-in-pywheel branch from 3b5dc2c to 2090a16 Compare March 21, 2024 12:18
@aignas aignas added this pull request to the merge queue Mar 21, 2024
Merged via the queue into bazelbuild:main with commit c5c03b2 Mar 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aignas aignas aignas approved these changes

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for python-wheel data directory
2 participants
@BradHolmes @aignas