Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/main' into use-com_google_prot…
Browse files Browse the repository at this point in the history
…obuf
  • Loading branch information
rickeylev committed Nov 21, 2024
2 parents 9b63950 + d73a74f commit 839c1c7
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 2 deletions.
21 changes: 21 additions & 0 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,27 @@ tasks:
<<: *common_workspace_flags
name: "Default: Windows, workspace"
platform: windows
# Most of tests/integration are failing on Windows w/workspace. Skip them
# for now until we can look into it.
build_targets:
- "--"
- "..."
# As a regression test for #225, check that wheel targets still build when
# their package path is qualified with the repo name.
- "@rules_python//examples/wheel/..."
build_flags:
- "--noenable_bzlmod"
- "--enable_workspace"
- "--keep_going"
- "--build_tag_filters=-integration-test"
- "--config=bazel7.x"
test_targets:
- "--"
- "..."
test_flags:
- "--noenable_bzlmod"
- "--enable_workspace"
- "--test_tag_filters=-integration-test"

debian:
<<: *reusable_config
Expand Down
5 changes: 3 additions & 2 deletions tests/integration/local_toolchains/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ def test_python_from_path_used(self):
[shell_path, "-c", "import sys; print(sys.executable)"],
text=True,
)
expected = expected.strip()
self.assertEqual(expected, sys.executable)
expected = expected.strip().lower()
# Normalize case: Windows may have case differences
self.assertEqual(expected.lower(), sys.executable.lower())


if __name__ == "__main__":
Expand Down

0 comments on commit 839c1c7

Please sign in to comment.