address comments

bazelbuild · May 14, 2024 · 4fe3109 · 4fe3109
1 parent d814250
commit 4fe3109
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 20 deletions.
diff --git a/MODULE.bazel b/MODULE.bazel
@@ -49,7 +49,7 @@ python.toolchain(
     is_default = True,
     python_version = "3.11",
 )
-use_repo(python, "python_versions", "pythons_hub")
+use_repo(python, "python_3_11", "python_versions", "pythons_hub")
 
 # This call registers the Python toolchains.
 register_toolchains("@pythons_hub//:all")

diff --git a/tests/BUILD.bazel b/tests/BUILD.bazel
@@ -25,22 +25,3 @@ build_test(
         "//python/entry_points:py_console_script_binary_bzl",
     ],
 )
-
-# Used for manual tests when downloading a toolchain for a particular platform
-platform(
-    name = "linux_x86_64",
-    constraint_values = [
-        "@platforms//cpu:x86_64",
-        "@platforms//os:linux",
-    ],
-    visibility = ["//:__subpackages__"],
-)
-
-platform(
-    name = "windows_x86_64",
-    constraint_values = [
-        "@platforms//cpu:x86_64",
-        "@platforms//os:windows",
-    ],
-    visibility = ["//:__subpackages__"],
-)
diff --git a/tests/support/BUILD.bazel b/tests/support/BUILD.bazel
@@ -37,3 +37,29 @@ platform(
         "@platforms//os:windows",
     ],
 )
+
+# Used when testing downloading of toolchains for a different platform
+
+platform(
+    name = "linux_x86_64",
+    constraint_values = [
+        "@platforms//cpu:x86_64",
+        "@platforms//os:linux",
+    ],
+)
+
+platform(
+    name = "mac_x86_64",
+    constraint_values = [
+        "@platforms//cpu:x86_64",
+        "@platforms//os:macos",
+    ],
+)
+
+platform(
+    name = "windows_x86_64",
+    constraint_values = [
+        "@platforms//cpu:x86_64",
+        "@platforms//os:windows",
+    ],
+)