Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't load cc toolchain from rules_cc #779

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Don't load cc toolchain from rules_cc #779

merged 4 commits into from
Nov 7, 2023

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Nov 7, 2023 •
edited
Loading

The cc toolchain autoconfig in rules_cc is out of sync from Bazel and doesn't work with VS2022.

Related: bazelbuild/continuous-integration#1770

@meteorcloudy
Don't load cc toolchain from rules_cc
84f5934 
The cc toolchain autoconfig is out of sync from Bazel and doesn't work with VS2022.

Related: bazelbuild/continuous-integration#1770
@meteorcloudy meteorcloudy mentioned this pull request Nov 7, 2023
Merged
aiuto
aiuto reviewed Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples/rich_structure/WORKSPACE needs the same change.

But the centos build fails now. with
  | gcc: error: unrecognized command line option '-std=c++14'

Did rules CC change in a way to believe it is always above 14?

WORKSPACE Outdated Show resolved Hide resolved
@meteorcloudy
Copy link
Member Author

Did rules CC change in a way to believe it is always above 14?

Yes, with Bazel@HEAD, we already switch the default C++ standard to 14: bazelbuild/bazel#18280

We should switch to use centos7_java11_devtoolset10 or just drop this platform.

aiuto
aiuto reviewed Nov 7, 2023
View reviewed changes
.bazelci/tests.yml Outdated Show resolved Hide resolved
@aiuto
Copy link
Collaborator

aiuto commented Nov 7, 2023

We should switch to use centos7_java11_devtoolset10 or just drop this platform.
We can't drop centos. We need it for the RPM builder tests.

@meteorcloudy
Copy link
Member Author

We can't drop centos. We need it for the RPM builder tests.

Got it, added in back in .bcr/presubmit.yml

alexeagle
alexeagle approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yun!

@aiuto aiuto merged commit e97d155 into main Nov 7, 2023
3 checks passed
@aiuto aiuto deleted the meteorcloudy-patch-1 branch November 7, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiuto aiuto aiuto approved these changes

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meteorcloudy @aiuto @alexeagle