Add basic include_runfiles to pkg_files. #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show it working in a mappings tests. Improve the mapping test to print something a little more useful. Next step: Make the same code callable from pkg_tar and pkg_zip
alexeagle
approved these changes
Aug 10, 2023
|
@aiuto Now that this has landed, are you planning to start work on the pkg_tar fix, or would you like me to pick that up? |
|
I'll continue for pkg_tar. I'm going to have to keep importing into
google3 to make sure I don't break everyone.
…On Wed, Aug 16, 2023 at 11:06 AM Alex Eagle ***@***.***> wrote:
@aiuto <https://github.com/aiuto> Now that this has landed, are you
planning to start work on the pkg_tar fix, or would you like me to pick
that up?
—
Reply to this email directly, view it on GitHub
<#724 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHBVEINU2JXK2HJJSODXVTOXVANCNFSM6AAAAAA3KSRYYU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @aiuto @alexeagle Thanks for this fix! could you update on this pkg_tar work? And will there be a new release soon that includes the new feature in pkg_files? |
|
The first of the PRs for that is out for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show it working in a mappings tests.
Improve the mapping test to print something a little more useful.
Next step: Make the same code callable from pkg_tar and pkg_zip