-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg_deb] Fix multiline fields in changes file #691
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Since I hardcoded the checksums in the test case the tests now show that on macos the resulting deb has a different checksum and the date is off by one hour in the changes file. I think ideally this rule should produce an identical package across different environments. |
5a1b8a0
to
4bf01b4
Compare
So then the question is if that is correct or not. IRRC, there were another set of bugs about the control file fields being wrong. I don't recall if they were on github or internal. |
https://www.debian.org/doc/debian-policy/ch-controlfields.html#description describes how |
i would suggest using |
before
after
|
@aiuto can you land this as I don't have access to that? |
Fix broken
.changes
file reported in #632As per documentation https://www.debian.org/doc/debian-policy/ch-controlfields.html#debian-changes-files-changes
Files and checksum fields always start with an empty line.
Fix this by marking the fields as
is_multiline=True
. Also remove the trailing whitespace after a single line includes just the field key. Added a test that checks for an exact match to generated.changes
file.fixes #632
fixes #659