Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply package_dir to pkg_mklink in pkg_tar #637

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Apply package_dir to pkg_mklink in pkg_tar #637

merged 1 commit into from
Nov 23, 2022

Conversation

aiuto
Copy link
Collaborator

@aiuto aiuto commented Nov 22, 2022

  • Fix brokenness in pkg_tar
  • Add tests (it was working) to pkg_zip

Fixes #610

@aiuto
Apply package_dir to pkg_mklink
d03fc90 
- Fix brokenness in pkg_tar
- Add tests (it was working) to pkg_zip

Fixes bazelbuild#610
@aiuto aiuto requested a review from nacl as a code owner November 22, 2022 19:34
nacl
nacl approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@nacl nacl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wonder how well this scales. It probably works well enough in 99% of the use cases in any cases; see the comment below.

Also, on submit, please call out pkg_tar in the commit summary (first line).

tests/tar/tar_writer_test.py Show resolved Hide resolved
@aiuto aiuto changed the title Apply package_dir to pkg_mklink Apply package_dir to pkg_mklink in pkg_tar Nov 23, 2022
@aiuto aiuto merged commit ecd5112 into bazelbuild:main Nov 23, 2022
@aiuto aiuto deleted the i610 branch November 23, 2022 19:45
@pauldraper pauldraper mentioned this pull request Nov 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nacl nacl nacl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package_dir attribute is not applied to pkg_mklink
2 participants
@aiuto @nacl