Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pkg_tar to not add the ./ to the prefix of every member. #554

Merged
merged 2 commits into from
Mar 5, 2022
Merged

Fix pkg_tar to not add the ./ to the prefix of every member. #554

merged 2 commits into from
Mar 5, 2022

Commits on Mar 3, 2022

  1. Fix pkg_tar to not add the ./ to the prefix of every member. 

    Fixes: bazelbuild#531

- Remove leading './' from merged tar files. Also applies to pkg_deb.
- Remove package_base from pkg_tar. Closes bazelbuild#549
- Use build_tar --directory as the prefix to add to everything.

Note that the code is intentionaly not testing use cases that try to add "./"
as an explicit root. This might still work, but it is a bad idea, for the
reasons described in bazelbuild#531 . If someone comes up with a real need for
using a leading "./" AND it does not work, they can file a feature
request to support it.
    @aiuto
    aiuto committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    97a4e2d View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. refactor out normpath

    @aiuto
    aiuto committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    acf200d View commit details
    Browse the repository at this point in the history