-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update make_deb.py to work for Python2 or 3 #47
Conversation
Mostly fixes #35 |
bazelbuild/bazel#8713. I think the easiest thing is to make it If a user doesn't have Python 3 installed but wants to run targets marked PY3 that are in reality compatible with both Python 2 and 3, they should use the non-strict toolchain (implemented in bazelbuild/bazel#8547). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super familiar with this code but looks plausible.
This way we can *not* use it for args of the form '@filename'. The filename portion will already be encoded in the proper format for the open call. And add a python2 test.
Also changed the default version to py3 and added a py2 test. |
I added changed to PY3 as the default and added a py2 test, so this is less important. I think I will merge and we'll see how that goes. |
Thanks for your work on this! Apologies for the slow reply, I have been on vacation. I tested the latest master here 96e34ab against my tree, and I can confirm that the |
Generally being more careful about unicode handling.
Some very weird magic with pre-processing argv to undo undesired interpreter behavior.
This leaves the code in a state where someone could use either interpreter.
Next step it to figure out how to select the python version to match whatever toolchain we have.