You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dpkg has supported zstd-compressed data since version 1.21.18 (and at least in ubuntu 22.04, dpkg 1.21.1 seems to also support it, though the feature is undocumented; I think the support is implicit through tar 1.31+). While pkg_tar does not yet directly support making zstd-compressed tarballs, aside from the possibility of constructing such tarballs by other means, one can still build them by supplying a custom compressor.
pkg_deb does not currently allow using a data.tar.zst, in two places:
which will strip off the .zst suffix, rendering the resulting .deb unusable.
Worth noting, every .deb archive that I've spot-checked in the Ubuntu jammy (22.04) repository has used data.tar.zst, which I'd say makes this a pretty main-stream feature.
The text was updated successfully, but these errors were encountered:
adam-azarchs
added a commit
to adam-azarchs/rules_pkg
that referenced
this issue
Oct 6, 2023
dpkg has officially supported zstandard compression for the data tarball
since version 1.21.18, and despite shipping with dpkg version 1.21.1,
most .deb packages for Ubuntu 22.04 are also in zst format.
While this PR does not do anything to make it easier to create
zstd-compressed tarballs, it does make it possible to use them when
creating .deb packages.
Closesbazelbuild#759
dpkg has officially supported zstandard compression for the data tarball
since version 1.21.18, and despite shipping with dpkg version 1.21.1,
most .deb packages for Ubuntu 22.04 are also in zst format.
While this PR does not do anything to make it easier to create
zstd-compressed tarballs, it does make it possible to use them when
creating .deb packages.
Closes#759
dpkg
has supported zstd-compressed data since version 1.21.18 (and at least in ubuntu 22.04, dpkg 1.21.1 seems to also support it, though the feature is undocumented; I think the support is implicit through tar 1.31+). Whilepkg_tar
does not yet directly support making zstd-compressed tarballs, aside from the possibility of constructing such tarballs by other means, one can still build them by supplying a customcompressor
.pkg_deb
does not currently allow using adata.tar.zst
, in two places:rules_pkg/pkg/private/deb/deb.bzl
Line 19 in ff60b34
disallows supplying a
tar.zst
. If one fixes that, there's alsorules_pkg/pkg/private/deb/make_deb.py
Lines 240 to 241 in ff60b34
which will strip off the
.zst
suffix, rendering the resulting.deb
unusable.Worth noting, every
.deb
archive that I've spot-checked in the Ubuntu jammy (22.04) repository has useddata.tar.zst
, which I'd say makes this a pretty main-stream feature.The text was updated successfully, but these errors were encountered: