Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print_rel_notes should support customizing tarball_name #435

Closed
guw opened this issue Oct 15, 2021 · 1 comment · Fixed by #541
Closed

print_rel_notes should support customizing tarball_name #435

guw opened this issue Oct 15, 2021 · 1 comment · Fixed by #541
Labels
P3 An issue that we are not working on but will review quarterly

Comments

@guw
Copy link
Contributor

guw commented Oct 15, 2021 •
edited
Loading

The tarball_name is currently hard coded in print_rel_notes to follow a strict pattern of repo name and version. This does not support the case where different name is used for the tar file. The call/build then fails with missing input file.
guw added a commit to guw/rules_pkg that referenced this issue Oct 15, 2021
@guw
Allow tarball_name as parameter
f8d9f70 
Fixes bazelbuild#435
@guw guw mentioned this issue Oct 15, 2021
Closed
guw added a commit to guw/rules_pkg that referenced this issue Oct 15, 2021
@guw
Allow tarball_name as parameter
101fffd 
Fixes bazelbuild#435
guw added a commit to guw/rules_pkg that referenced this issue Oct 15, 2021
@guw
Allow tarball_name as parameter
6ae1eda 
Fixes bazelbuild#435
@aiuto aiuto added the P3 An issue that we are not working on but will review quarterly label Nov 10, 2021
@guw
Copy link
Contributor Author

guw commented Nov 29, 2021

@aiuto I'd like to give it another try. Do you have an idea for implementation?

aiuto added a commit to aiuto/rules_pkg that referenced this issue Feb 14, 2022
@aiuto
Add artifact_name to print_relnotes
679c567 
This allows you to use artifact names that do not follow the standard convention.

Fixes bazelbuild#435
@aiuto aiuto mentioned this issue Feb 14, 2022
Merged
aiuto added a commit that referenced this issue Feb 15, 2022
@aiuto
Add artifact_name to print_relnotes (#541)
a6037f0 
This allows you to use artifact names that do not follow the standard convention.

Fixes #435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 An issue that we are not working on but will review quarterly
Projects
None yet
Milestone
No milestone
2 participants
@guw @aiuto