Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no way to tell pkg_tar to not change mtime of the packaged files. #265

Open
konste opened this issue Dec 17, 2020 · 5 comments
Open
Labels
P2 An issue that should be worked on when time is available

Comments

@konste
Copy link
Contributor

konste commented Dec 17, 2020

When pkg_tar mtime attribute is not set (or set to its default value -1) I expected the packaged files to retain their original mtime within the archive. Unfortunately it looks like their mtime is set to Jan 1st 1970 (or Jan 1st 2000 depending on portable_mtime attribute). I could not find a way to make pkg_tar to preserve the files mtime.

@aiuto aiuto added the P2 An issue that should be worked on when time is available label May 3, 2021
@aiuto
Copy link
Collaborator

aiuto commented May 6, 2021

Strawman proposal:

  • pkg_tar should no long auto-unfurl tarballs, and we will not implement a change for that legacy behavior
  • add pkg_unfurl which takes tar or zip srcs and returns a provider that specifes the unwrapping of each, with options to
    • strip_prefix
    • add a new prefix
    • change owners
    • preserve mtimes
    • the other kinds of stuff that pkg_files might do.

Or maybe it just does the virtual unfurl with ability to preserve mtimes and then pkg_files will to do the rest.

@konste
Copy link
Contributor Author

konste commented May 7, 2021

I'm sorry, what is auto-unfurl tarballs? You do what with what?

@aiuto
Copy link
Collaborator

aiuto commented May 7, 2021 via email

@konste
Copy link
Contributor Author

konste commented May 7, 2021

Ah, I see. It makes sense now.

@aiuto
Copy link
Collaborator

aiuto commented Nov 1, 2021

Note from eng meeting. This is probably a dup of the pkg_expand issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 An issue that should be worked on when time is available
Projects
None yet
Development

No branches or pull requests

2 participants