Skip to content

Commit

Permalink
Ensure the experimental/ tree lands in the output release archive (#142)
Browse files Browse the repository at this point in the history
The `experimental/` tree containing the then `pkgfilegroup` rule was missing
from the 0.2.5 release archive.

This change ensures that the files in the experimental/ tree are included in
release packages so users can use the rules within.

Testing was done by trying to run the experimental `pkg_rpm` rule on a dummy
project importing rules_pkg.
  • Loading branch information
Andrew Psaltis authored Apr 28, 2020
1 parent 716172c commit 642022a
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 1 deletion.
9 changes: 8 additions & 1 deletion pkg/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,14 @@ exports_files(

filegroup(
name = "standard_package",
srcs = glob(["BUILD", "*.bzl", "*.py", "*.md"]),
srcs = glob([
"*.bzl",
"*.py",
"*.md",
]) + [
"BUILD",
"//experimental:standard_package",
],
visibility = ["@//distro:__pkg__"],
)

Expand Down
12 changes: 12 additions & 0 deletions pkg/experimental/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,15 @@ py_binary(
"@rules_pkg//:make_rpm_lib",
],
)

filegroup(
name = "standard_package",
srcs = glob([
"*.bzl",
"*.py",
]) + [
"BUILD",
"template.spec.in",
],
visibility = ["@//:__pkg__"],
)

0 comments on commit 642022a

Please sign in to comment.