Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow java 15 and 17 for jvm_target #712

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

andrewhamon
Copy link
Contributor

@andrewhamon andrewhamon commented Apr 7, 2022

This seems to fix #711

I've tested some Kotlin targets at my company that depend on java deps and I can successfully build with java 17, but haven't done anything more thorough than that.

Also, what do y'all think about removing the check altogether? Kotlin compiler will fail if an invalid version is provided anyways, and this Bazel-level check doesn't even spare users from that error if they try to use java 17 with a Kotlin compiler that is too old.

@google-cla
Copy link

google-cla bot commented Apr 7, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@Bencodes
Copy link
Collaborator

Also, what do y'all think aout removing the check altogether?

This would be a better question for @restingbull

@Bencodes
Copy link
Collaborator

@andrewhamon can you also update the ## Custom toolchain section in the root README.md to list the newly supported jvm targets?

@Bencodes Bencodes merged commit d1be914 into bazelbuild:master Apr 22, 2022
@andrewhamon
Copy link
Contributor Author

@Bencodes just circled back to update the readme only to find you did it for me... thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not use with Java versions newer than 13
3 participants