Remove legacy Javac compilation #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
requested review from
cgruber,
jin,
timpeut and
restingbull
as code owners
Bencodes
force-pushed
the
enable-experimental_use_abi_jars-by-default-and-remove-legacy-javac-compilation
branch
from
bb7833a to
1dab3a1
Compare
Bencodes
force-pushed
the
enable-experimental_use_abi_jars-by-default-and-remove-legacy-javac-compilation
branch
from
14c2982 to
ae2b517
Compare
Bencodes
changed the title
…es/jetpack_compose/BUILD
nkoroste
reviewed
Mar 14, 2022
| @@ -90,13 +88,6 @@ class KotlinJvmTaskExecutor @Inject internal constructor( | |||
| emptyList() | |||
| } | |||
| } | |||
| context.execute("javac") { | |||
There was a problem hiding this comment.
It looks to me that we were compiling java twice, once here and once in https://sourcegraph.com/github.com/bazelbuild/rules_kotlin/-/blob/kotlin/internal/jvm/compile.bzl?L699
I'm still testing this against our code base but so far it seems like it's safe to remove this -- didn't notice huge perf gains but we dont have that much java in our codebase
restingbull
approved these changes
Mar 16, 2022
|
@restingbull sounds good. I'm going to merge this one in and we can look into the java_home/rbe issues async d0abebe |
illicitonion
added a commit
to illicitonion/rules_kotlin-mixed-compile-repro
that referenced
this pull request
Mar 30, 2022
To repro, run `./run.sh` Before bazelbuild/rules_kotlin#694 this succeeded, now it fails.
illicitonion
added a commit
to illicitonion/rules_kotlin-mixed-compile-repro
that referenced
this pull request
Mar 30, 2022
To repro, run `./run.sh` Before bazelbuild/rules_kotlin#694 this succeeded, now it fails.
Bencodes
deleted the
enable-experimental_use_abi_jars-by-default-and-remove-legacy-javac-compilation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes: