Generic -Xopt-in support #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugarmanz
requested review from
cgruber,
jin,
restingbull and
timpeut
as code owners
restingbull
approved these changes
Mar 4, 2022
|
TODO: Resolve conflicts. |
Bencodes
approved these changes
Mar 9, 2022
This was referenced Mar 18, 2022
|
Is it possible to backport this change to 1.5.x branch and make another release while 1.6 is still in progress? |
|
I think it would be great to see smaller but more frequent releases. The cadance in the past has been 6mos-1yr between releases. In my opinion, it would be better to have a release every 2-3 months with whatever changes and fixes have been made during that period. In addition to benefiting end-users, I feel like this would also generate more activity on the project itself. It feels like there are enough improvements in just in the past 2 months to justify a 1.6.0 release. What do you guys think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired from conversation on #653 to solve for #603.
I'm only opening this PR because this is a feature I needed today and haven't seen any movement on #653 in almost a month. Feel free to disregard if this PR is redundant pending work from #653.
If necessary, I can add to some of the other
opts.bzlfiles, but it wasn't clear to me the resolution of this comment since the PR was approved afterwards:#653 (comment)