Build rules_kotlin using Kotlin 1.6 #626
Conversation
Bencodes
requested review from
cgruber,
jin,
restingbull and
timpeut
as code owners
|
Will wait for https://github.com/bazelbuild/rules_kotlin/pull/625/files to merge |
Bencodes
force-pushed
the
build-rules_kotlin-using-kotlin-1.6
branch
from
3bed8c8 to
a91b668
Compare
|
1.6.10-RC is out with some critical fixes that we need. Going to wait until that rolls out to merge this. |
hopefully they land JetBrains/kotlin#4677 in there as well |
Sorry, the PR was uploaded after the RC release and it didn't make it into 1.6.10. Does this issue affect you? I was hoping that nobody else was using ABI jars as dependencies in IntelliJ. |
Bencodes
force-pushed
the
build-rules_kotlin-using-kotlin-1.6
branch
from
ae40961 to
ed2f8da
Compare
|
@sfs any idea when 1.6.20 will hit RC so that we can do another round of testing? |
Bencodes
force-pushed
the
build-rules_kotlin-using-kotlin-1.6
branch
from
7ff9e6e to
9b28031
Compare
| @@ -38,6 +38,7 @@ public void testGeneratesAbiOnly() { | |||
| c.compileKotlin(); | |||
| c.outputJdeps(); | |||
| c.outputJavaJdeps(); | |||
| c.outputJar(); | |||
There was a problem hiding this comment.
Without this, the skip-code-gen plugin gets added, which causes the new ABI compiler to short circuit and not output anything.
|
This is still blocked by the metadata fixes that will go out in |
|
@Bencodes Kotlin v1.6.20 is out now. |
Bencodes
force-pushed
the
build-rules_kotlin-using-kotlin-1.6
branch
from
86d3335 to
f596f1e
Compare
Bencodes
force-pushed
the
build-rules_kotlin-using-kotlin-1.6
branch
from
01950b9 to
dce2639
Compare
|
@restingbull @nkoroste this should be good to merge now if you want to give it a once over. |
|
I'll update the compose example after they update that with the latest Kotlin compatibility. |
This PR also includes:
-Xuse-experimental=kotlin.Experimentalas-Xopt-inis now the default for 1.6.xhttps://github.com/JetBrains/kotlin/releases/tag/v1.6.20