Tweak the inference of the test class's package a bit #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/test/kotlin/ and kotlin/, since while it's common for kotlin files to live in a /java/ root, it's not UNcommon for them to live in a *kotlin/ root.
cgruber
added
type: enhancement
cgruber
requested review from
djwhang,
git-str,
jin,
thomaswk and
timpeut
as code owners
jin
approved these changes
Jan 15, 2020
cgruber
added
status: closed - fixed
and removed
status: in review
cgruber
added a commit
to cgruber/rules_kotlin
that referenced
this pull request
Feb 10, 2020
* upstream/master: typo and add missing paren. Add release legacy-1.3.0 Reference proper "current release" as legacy 1.3.0 Update README to account for legacy-1.3.0 release. Fix bad date in changelog Release the Kotlin rules in a simplified workspace relying on precompiled jars. (bazelbuild#271) Update CODEOWNERS (remove str, thomaswk) (bazelbuild#272) Factor out external workspace versions and SHA256s into variables conveniently placed at the top. (bazelbuild#259) Add a link to the generated documentation (bazelbuild#237) Stop using native java rules (bazelbuild#258) Add InteliiJ aspect info (bazelbuild#242) Change readme file formatting (bazelbuild#243) Update CHANGELOG.md Update readme to release candidate 4 Tweak the inference of the test class's package a bit, to support src/test/kotlin/ and kotlin/, since while it's common for kotlin files to live in a /java/ root, it's not UNcommon for them to live in a *kotlin/ root. (bazelbuild#257) Passthrough tags to the container android_library (bazelbuild#255) Fix current "latest" to actually be the latest. Update CHANGELOG.md Update to release legacy-1.3.0-rc3 Support more recent java versions in the kotlin toolchain. (bazelbuild#236)
cgruber
added a commit
to cgruber/rules_kotlin
that referenced
this pull request
Feb 10, 2020
* origin/master: Stop using native java rules (bazelbuild#258) Add InteliiJ aspect info (bazelbuild#242) Change readme file formatting (bazelbuild#243) Update CHANGELOG.md Update readme to release candidate 4 Tweak the inference of the test class's package a bit, to support src/test/kotlin/ and kotlin/, since while it's common for kotlin files to live in a /java/ root, it's not UNcommon for them to live in a *kotlin/ root. (bazelbuild#257) Passthrough tags to the container android_library (bazelbuild#255) Fix current "latest" to actually be the latest.
jongerrish
added a commit
to jongerrish/rules_kotlin
that referenced
this pull request
Apr 16, 2020
…/test/kotlin/ and kotlin/, since while it's common for kotlin files to live in a /java/ root, it's not UNcommon for them to live in a *kotlin/ root. (bazelbuild#257)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak the inference of the test class's package a bit, to support src/test/kotlin/ and kotlin/, since while it's common for kotlin files to live in a /java/ root, it's not UNcommon for them to live in a *kotlin/ root.