-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Kotlin 1.3 #195
Conversation
# Conflicts: # third_party/jvm/workspace.bzl
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
I'm glad you took inspiration, but the reason I'm keeping it in my fork, and haven't filed more or less this PR, is that the team has indicated that they're not going to take patches to the legacy rules, until they've published the new rules according to the roadmap. So I just haven't bugged the team with PRs like this, because they're super busy trying to get the new rules out, and there's less friction just maintaining my fork. 🤷♂ |
@jin - has that position changed? |
@cgruber Glad you didn't keep it private. Figuring what the hell is wrong with Kapt would be a nightmare by myself :) |
Some of it is pretty arcane, it's true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Could you please revert the indentation changes so the diff is minimal?
As mentioned in #159 (comment), we'll be working with @cgruber to merge his fork to this repo. Thank you @AlexeySoshin for creating this PR! |
Ruleset for Kotlin 1.3 used @wix
Inspired by https://github.com/cgruber/rules_kotlin
@cgruber