Added support for bazel generated embeded jar resources. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hsyed could you pls take a look? |
|
@jin Does this PR make sense to you? |
|
As I understand it, this repo won't be taking more patches until the internal google rules are pushed out. I'm bringing my repo http://github.com/cgruber/rules_kotlin more up to date, if you want to contribute there, and we can chat with the google team once they're in a position to take patches on what parts of that fork to bring in. |
jin
reviewed
Aug 9, 2019
| @@ -52,6 +52,8 @@ def _fold_jars_action(ctx, rule_kind, output_jar, input_jars): | |||
| _CONVENTIONAL_RESOURCE_PATHS = [ | |||
| "src/main/resources", | |||
| "src/test/resources", | |||
| "bazel-out/k8-fastbuild/genfiles", | |||
There was a problem hiding this comment.
This seems odd. We shouldn't depend on bazel-* paths, especially if they have configuration parameters in them, like k8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, generated files could not be located when placed as
resourcesattribute. Current code uses.short_pathwhich works fine for regular files. Howver, generated files are placed underbazel-out/k8-fastbuild/genfileswhich is not in the source tree. This change addsbazel-out/k8-fastbuild/genfilesto the list of_CONVENTIONAL_RESOURCE_PATHSthus this prefix is removed before adding the resource into the jar file.