[infra] Use kotlin standard libraries from the toolchain, as opposed to hard coded. #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
reviewed
Oct 4, 2024
restingbull
force-pushed
the
restingbull-keep-metadata
branch
from
459be1f to
22c1cff
Compare
restingbull
requested review from
ahumesky,
cgruber and
nkoroste
as code owners
Bencodes
reviewed
Oct 5, 2024
| @@ -27,3 +27,16 @@ ktlint_config( | |||
| experimental_rules_enabled = False, | |||
| visibility = ["//visibility:public"], | |||
| ) | |||
|
|
|||
| sh_test( | |||
There was a problem hiding this comment.
There's a skylib macro for this that asserts if something builds.
Probably worth using just to minimize the surface area of rules Kotlin a bit.
There was a problem hiding this comment.
Needs to run to test it. Building is easy -- but the kotlin/jvm integration will only fail if it doesn't run.
restingbull
changed the title
nkoroste
approved these changes
Oct 7, 2024
| @@ -122,7 +126,7 @@ _kt_toolchain = rule( | |||
| ), | |||
| "language_version": attr.string( | |||
| doc = "this is the -language_version flag [see](https://kotlinlang.org/docs/reference/compatibility.html)", | |||
| default = "2.0", | |||
| default = "1.9", | |||
There was a problem hiding this comment.
why are we going back to an older version?
Yes, this seems to work! |
|
master...agluszak:agluszak/fix I got 2.0 working in this branch! this is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the toolchain to provide a common set of stdlib for the builder and jdeps merger via the classpath advice on a java binary.
Also extends the
examples/trivialto validate the built binary executes as part of testing the java/kotlin integration.Aside from improving correctness, the hope is that this will fix the link error seen when upgrading to newer versions of kotlinc.