Add warning as error to the warn option.

Matches Gradle's equivalent option (AllWarningsAsErrors).
bazelbuild · Nov 17, 2020 · b7f5832 · b7f5832
1 parent 4811a43
commit b7f5832
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/kotlin/internal/jvm/compile.bzl b/kotlin/internal/jvm/compile.bzl
@@ -338,8 +338,10 @@ def _kotlinc_options_provider_to_flags(opts):
     if not opts:
         return ""
     flags = []
-    if not opts.warn:
+    if opts.warn == "off":
         flags.append("-nowarn")
+    elif opts.warn == "error":
+        flags.append("-Werror")
     if opts.x_use_experimental:
         flags.append("-Xuse-experimental=kotlin.Experimental")
     if opts.x_use_ir:
@@ -354,8 +356,10 @@ def _javac_options_provider_to_flags(opts):
     if not opts:
         return ""
     flags = []
-    if not opts.warn:
+    if opts.warn == "off":
         flags.append("-nowarn")
+    elif opts.warn == "error":
+        flags.append("-Werror")
     if opts.x_ep_disable_all_checks:
         flags.append("-XepDisableAllChecks")
     if opts.x_lint:

diff --git a/kotlin/internal/opts.bzl b/kotlin/internal/opts.bzl
@@ -15,10 +15,11 @@
 _KOPTS = {
     "warn": struct(
         args = dict(
-            default = True,
-            doc = "Enable or disable compiler warnings.",
+            default = "report",
+            doc = "Control warning behaviour.",
+            values = ["off", "report", "error"],
         ),
-        type = attr.bool,
+        type = attr.string,
     ),
     "x_use_experimental": struct(
         args = dict(
@@ -77,10 +78,11 @@ kt_kotlinc_options = rule(
 _JOPTS = {
     "warn": struct(
         args = dict(
-            default = True,
-            doc = "Enable or disable compiler warnings.",
+            default = "report",
+            doc = "Control warning behaviour.",
+            values = ["off", "report", "error"],
         ),
-        type = attr.bool,
+        type = attr.string,
     ),
     "x_ep_disable_all_checks": struct(
         args = dict(