Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Update multiple dependency versions. #673

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

mishas
Copy link
Contributor

@mishas mishas commented Oct 20, 2021

This PR takes care of a bunch of subtasks of #672
And also closes #587, #632, #645

Dependencies updated are:

  • Bazel (in .bazelversion)
  • protobuf (in WORKSPACE)
  • rules_python (in WORKSPACE)
  • grpc (in WORKSPACE)
  • rules_jsonnet (in WORKSPACE)
  • PyYaml (in k8s/k8s.bzl and requirements.txt)
  • rules_go (in k8s/k8s.bzl)
  • gazelle (in k8s/k8s.bzl)
  • skylib (in k8s/k8s.bzl)
  • go-cmp (in k8s/k8s_go_deps.bzl)
  • Go compiler version (in k8s/k8s_go_deps.bzl)

@k8s-ci-robot
Copy link

Hi @mishas. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta
Copy link
Contributor

fejta commented Oct 20, 2021

/ok-to-test

@mishas
Copy link
Contributor Author

mishas commented Oct 20, 2021

Hello @fejta ,

So - it seems like the tests are failing due to the version of Bazel that I've updated:

ERROR: The project you're trying to build requires Bazel 4.2.1 (specified in /home/prow/go/src/github.com/bazelbuild/rules_k8s/.bazelversion), but it wasn't found in /usr/local/lib/bazel/bin.

and

Current Bazel version is 2.2.0, expected at least 4.2.0

Version 4.2.0 (or higher) is now required for the latest rules_go (see https://github.com/bazelbuild/rules_go/releases/tag/v0.29.0) as well as for the latest gazelle.

I'm not exactly sure how the CI system is configured, and how I can make it have Bazel 4.2.0 or higher. Can you give me some pointers please?

Thanks.

@mishas
Copy link
Contributor Author

mishas commented Oct 20, 2021

@fejta ,

Actually, just noticed min_supported_version in .bazelci/presubmit.yml was 2.2.0, and updated it. Can we please retest?

Thanks.

@mishas mishas force-pushed the update_dependencies branch from 3dad506 to e6db64c Compare October 20, 2021 18:40
@mishas
Copy link
Contributor Author

mishas commented Oct 20, 2021

@fejta ,

As you can see, I fixed the rest of the build problems and am just left with praw not being happy:

ERROR: The project you're trying to build requires Bazel 4.2.1 (specified in /home/prow/go/src/github.com/bazelbuild/rules_k8s/.bazelversion), but it wasn't found in /usr/local/lib/bazel/bin.
Bazel binaries for all official releases can be downloaded from here:
  https://github.com/bazelbuild/bazel/releases
You can download the required version directly using this command:
  (cd "/usr/local/lib/bazel/bin" && curl -fLO https://releases.bazel.build/4.2.1/release/bazel-4.2.1-linux-x86_64 && chmod +x bazel-4.2.1-linux-x86_64)

How do we update the image Praw uses to include bazel v4.2.1 (or v4.2.0)?

Thanks

@mishas
Copy link
Contributor Author

mishas commented Oct 27, 2021

/assign @fejta

@mishas
Copy link
Contributor Author

mishas commented Nov 3, 2021

/assign @chizhg

@fejta
Copy link
Contributor

fejta commented Jun 15, 2022

This repo now uses 5.2.0 for unit testing. Any chance you'd like to rebase it and see if it passes tests? Or would you prefer to close it out?

This PR takes care of a bunch of subtasks of bazelbuild#672
And also closes bazelbuild#587, bazelbuild#632, bazelbuild#645
@mishas mishas force-pushed the update_dependencies branch from e6db64c to 5ce2e82 Compare June 16, 2022 00:49
@mishas
Copy link
Contributor Author

mishas commented Jun 16, 2022

Hello @fejta, After rebasing and resolving conflicts, the change is much smaller than before, but still does updates a few things. I'd love to merge if possible.
Thanks.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, mishas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta
Copy link
Contributor

fejta commented Jun 16, 2022

That is for the contribution and especially for being so excessively patient!

@fejta fejta merged commit 8d24cac into bazelbuild:master Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rules_docker to 0.14.4 or later
4 participants