-
Notifications
You must be signed in to change notification settings - Fork 136
Conversation
Hi @mishas. Thanks for your PR. I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Hello @fejta , So - it seems like the tests are failing due to the version of Bazel that I've updated:
and
Version 4.2.0 (or higher) is now required for the latest rules_go (see https://github.com/bazelbuild/rules_go/releases/tag/v0.29.0) as well as for the latest gazelle. I'm not exactly sure how the CI system is configured, and how I can make it have Bazel 4.2.0 or higher. Can you give me some pointers please? Thanks. |
@fejta , Actually, just noticed Thanks. |
3dad506
to
e6db64c
Compare
@fejta , As you can see, I fixed the rest of the build problems and am just left with praw not being happy:
How do we update the image Praw uses to include bazel v4.2.1 (or v4.2.0)? Thanks |
/assign @fejta |
/assign @chizhg |
This repo now uses 5.2.0 for unit testing. Any chance you'd like to rebase it and see if it passes tests? Or would you prefer to close it out? |
This PR takes care of a bunch of subtasks of bazelbuild#672 And also closes bazelbuild#587, bazelbuild#632, bazelbuild#645
e6db64c
to
5ce2e82
Compare
Hello @fejta, After rebasing and resolving conflicts, the change is much smaller than before, but still does updates a few things. I'd love to merge if possible. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fejta, mishas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
That is for the contribution and especially for being so excessively patient! |
This PR takes care of a bunch of subtasks of #672
And also closes #587, #632, #645
Dependencies updated are: