This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
I'm using nix with home-manager, and my binaries doesn't live in a "conventional" folder.
It seems that the actual tooling succeeds to find xz_path but fails detect
xzcat
or when trying to directly usexz
in a subprocess.With xzcat in a non conventional folder but in PATH, the
archive.py
fails withxzcat not found
.What is the new behavior?
Since the path of
xz
is properly found inbuild_tar.py
, provide the path forxz
toarchive.py
and replace usage ofxz
andxzcat
with the provided path.Also added support for lzma in
archive.py
in a similar fashion thanbuild_tar.py
.Does this PR introduce a breaking change?
Other information
I was wondering if this should be replaced with proper settings given to tarfile or directly using lzma python library.
I feel that it is not well supported in python2, but do we still support python2 ?