Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose a way to specify os.version for images #1429

Closed
jonjohnsonjr opened this issue Feb 20, 2020 · 0 comments · Fixed by #1430
Closed

Expose a way to specify os.version for images #1429

jonjohnsonjr opened this issue Feb 20, 2020 · 0 comments · Fixed by #1430
Assignees
@jonjohnsonjr

Comments

@jonjohnsonjr
Copy link
Contributor

Similar to #1427 but for os.version.

I'd love for os.version information to get propagated down into the config file, like architecture and os. This would simplify a lot of things re: constructing windows images. There is an existing test here but that field gets dropped currently when using rules_docker to import and push.

Related: google/go-containerregistry#676
jonjohnsonjr added a commit to jonjohnsonjr/rules_docker that referenced this issue Feb 20, 2020
@jonjohnsonjr
Plumb os.version through container image config files.
5116c35 
Fixes bazelbuild#1429
jonjohnsonjr added a commit to jonjohnsonjr/rules_docker that referenced this issue Feb 20, 2020
@jonjohnsonjr
Plumb os.version through container image config files.
73ffa7f 
Fixes bazelbuild#1429
jonjohnsonjr added a commit to jonjohnsonjr/rules_docker that referenced this issue Feb 21, 2020
@jonjohnsonjr
Plumb os.version through container image config files.
14d1392 
Fixes bazelbuild#1429
jonjohnsonjr added a commit to jonjohnsonjr/rules_docker that referenced this issue Feb 21, 2020
@jonjohnsonjr
Plumb os.version through container image config files.
6849e8d 
Fixes bazelbuild#1429
@jonjohnsonjr jonjohnsonjr mentioned this issue Feb 21, 2020
Merged
jonjohnsonjr added a commit to jonjohnsonjr/rules_docker that referenced this issue Feb 21, 2020
@jonjohnsonjr
Plumb os.version through container image config files.
c75aa7a 
Fixes bazelbuild#1429
smukherj1 pushed a commit that referenced this issue Feb 21, 2020
@jonjohnsonjr
Plumb os.version through container image config files. (#1430)
634ff5b 
* Plumb os.version through container image config files.

Fixes #1429

* Trim down expected 401 strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonjohnsonjr jonjohnsonjr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plumb os.version through container image config files. jonjohnsonjr/rules_docker
1 participant
@jonjohnsonjr