Skip to content

Commit

Permalink
Disable caching for install_pkgs_reproducibility_test deps
Browse files Browse the repository at this point in the history
download_pkgs is not hermetic as it goes out to the package repository to fetch packages.
If the remote apt repository gets updated, the bazel cache can get into a weird state.
  • Loading branch information
laurynaslubys committed Apr 25, 2022
1 parent 6ea707b commit 97184e0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ test:remote --remote_timeout=3600
test:remote --keep_going

# Configuration specific to buildkite CI testing the default workspace
test:buildkite --action_env=PATH
test:buildkite --define=ENV_KEY=my_key # for tests/container:set_env_make_vars_test
test:buildkite --define=ENV_VALUE=my_value # for tests/container:set_env_make_vars_test
test:buildkite --action_env=PATH
test:buildkite --define=ENV_KEY=my_key # for tests/container:set_env_make_vars_test
test:buildkite --define=ENV_VALUE=my_value # for tests/container:set_env_make_vars_test
test:buildkite --test_output=errors
test:buildkite --experimental_allow_tags_propagation
2 changes: 2 additions & 0 deletions tests/docker/package_managers/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -131,13 +131,15 @@ install_pkgs(
image_tar = "@ubuntu1604//:ubuntu1604_vanilla.tar",
installables_tar = ":download_pkg_git.tar",
output_image_name = "test_install_pkgs_duplicate",
tags = ["no-cache"],
)

install_pkgs(
name = "install_git_for_reproducibility_2",
image_tar = "@ubuntu1604//:ubuntu1604_vanilla.tar",
installables_tar = ":download_pkg_git.tar",
output_image_name = "test_install_pkgs_duplicate",
tags = ["no-cache"],
)

compare_ids_test(
Expand Down

0 comments on commit 97184e0

Please sign in to comment.