Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dagger related NoClassDefFoundError: javax/annotation/Generated on Java 9 #234

Closed
davido opened this issue Dec 6, 2017 · 1 comment
Closed

Comments

@davido
Copy link
Contributor

davido commented Dec 6, 2017

We have this Bazel patch: hhclam/bazel@64212c8. See also diskussion: bazelbuild/bazel#3410. And this auto-value issue: google/auto#560.

With the Bazel patch above and this gerrit patch: [1], temporary adding javax.annotation:javax.annotation-api:1.3.1 as the project dependency, i was able to build GWT UI based gerrit@HEAD. Trying to build JS gerrit stack, rules_closure is failing with dagger related issue: [2].

[1] http://paste.openstack.org/show/628312
[2] http://paste.openstack.org/show/628314

@davido
Copy link
Contributor Author

davido commented Feb 7, 2018

This is fixed in latest dagger release.

@davido davido closed this as completed Feb 7, 2018
lucamilanesio pushed a commit to GerritCodeReview/gerrit that referenced this issue Feb 8, 2018
We need to upgrade rules_closure tools to be able to build with Java 9.
That's because rules_closure depends on dagger 2 and auto-common and
auto-value, that need to be updated to not depend on legacy annotations
(that are not available on Java 9). Moreover, latest rules_closure
switched to building protobuf library from the sources, creating the
next problem: Protobuf doesn't support Java 9 yet. That was fixed only
on master, so that we need to update rules_closure to consume the
protobuf dependency from HEAD.

See these issues for more background: [1],[2],[3],[4].

[1] google/auto#560
[2] bazelbuild/rules_closure#234
[3] google/dagger#880
[4] protocolbuffers/protobuf#4256

Bug: Issue 7958
Change-Id: I56f3b6101e06bd678b4e42d3a9d52157963513aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant