You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the Bazel patch above and this gerrit patch: [1], temporary adding javax.annotation:javax.annotation-api:1.3.1 as the project dependency, i was able to build GWT UI based gerrit@HEAD. Trying to build JS gerrit stack, rules_closure is failing with dagger related issue: [2].
We need to upgrade rules_closure tools to be able to build with Java 9.
That's because rules_closure depends on dagger 2 and auto-common and
auto-value, that need to be updated to not depend on legacy annotations
(that are not available on Java 9). Moreover, latest rules_closure
switched to building protobuf library from the sources, creating the
next problem: Protobuf doesn't support Java 9 yet. That was fixed only
on master, so that we need to update rules_closure to consume the
protobuf dependency from HEAD.
See these issues for more background: [1],[2],[3],[4].
[1] google/auto#560
[2] bazelbuild/rules_closure#234
[3] google/dagger#880
[4] protocolbuffers/protobuf#4256
Bug: Issue 7958
Change-Id: I56f3b6101e06bd678b4e42d3a9d52157963513aa
We have this Bazel patch: hhclam/bazel@64212c8. See also diskussion: bazelbuild/bazel#3410. And this auto-value issue: google/auto#560.
With the Bazel patch above and this gerrit patch: [1], temporary adding
javax.annotation:javax.annotation-api:1.3.1
as the project dependency, i was able to build GWT UI based gerrit@HEAD. Trying to build JS gerrit stack, rules_closure is failing with dagger related issue: [2].[1] http://paste.openstack.org/show/628312
[2] http://paste.openstack.org/show/628314
The text was updated successfully, but these errors were encountered: