Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest version of rules_go #144

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

aranguyen
Copy link
Contributor

@aranguyen aranguyen commented Sep 13, 2022

@aranguyen
Copy link
Contributor Author

@Wyverald @meteorcloudy can either of you help with the import?

@meteorcloudy
Copy link
Member

/cc @oquenchil Should be able to help!

oquenchil
oquenchil previously approved these changes Sep 15, 2022
Copy link
Contributor

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oquenchil
Copy link
Contributor

Can you sync? When trying to merge internally it complains about merge conflicts.

@meteorcloudy
Copy link
Member

https://github.com/aranguyen/rules_cc/commits/main is already synced with https://github.com/bazelbuild/rules_cc/commits/main

@aranguyen
Copy link
Contributor Author

@comius Pedro seems to be OOO until next monday, could you please help me with the merge as this is blocking for our 6.0 release? Thank you

@copybara-service copybara-service bot merged commit 16a4dfe into bazelbuild:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants