Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respectful code cleanup: rename master branch to main #107

Open
hlopko opened this issue Jun 25, 2021 · 5 comments
Open

Respectful code cleanup: rename master branch to main #107

hlopko opened this issue Jun 25, 2021 · 5 comments
Assignees
@aiuto

Comments

@hlopko
Copy link
Member

hlopko commented Jun 25, 2021

Same task with the same justification as bazelbuild/bazel#12200.
@aiuto
Copy link
Contributor

aiuto commented Jun 25, 2021

I plan to rename several sites on Monday 2021-06-28. That way if there is any fallout from automatic processes with a stale branch name I can be available to fix or advise.

@aiuto aiuto self-assigned this Jun 25, 2021
@aiuto
Copy link
Contributor

aiuto commented Jun 28, 2021

The branch is renamed

@aiuto aiuto closed this as completed Jun 28, 2021
@viblo
Copy link

viblo commented Jun 28, 2021

I just installed Bazelisk, and then tried to build "mediapipe" project, which gives me 404. It seems like the branch renaming is the reason:

INFO: Repository rules_cc instantiated at:
/home/vb/code/gh/google/mediapipe/WORKSPACE:36:13: in
Repository rule http_archive defined at:
/home/vb/.cache/bazel/_bazel_vb/a41a00c949dc2b3a22fd05f82d8c05c2/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in
WARNING: Download from https://github.com/bazelbuild/rules_cc/archive/master.zip failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 404 Not Found
ERROR: An error occurred during the fetch of repository 'rules_cc':
Traceback (most recent call last):
File "/home/vb/.cache/bazel/_bazel_vb/a41a00c949dc2b3a22fd05f82d8c05c2/external/bazel_tools/tools/build_defs/repo/http.bzl", line 111, column 45, in _http_archive_impl
download_info = ctx.download_and_extract(
Error in download_and_extract: java.io.IOException: Error downloading [https://github.com/bazelbuild/rules_cc/archive/master.zip] to /home/vb/.cache/bazel/_bazel_vb/a41a00c949dc2b3a22fd05f82d8c05c2/external/rules_cc/temp15386256763950372734/master.zip: GET returned 404 Not Found
ERROR: While resolving toolchains for target //mediapipe/examples/desktop/hello_world:hello_world: com.google.devtools.build.lib.packages.RepositoryFetchException: no such package '@rules_cc//cc': java.io.IOException: Error downloading [https://github.com/bazelbuild/rules_cc/archive/master.zip] to /home/vb/.cache/bazel/_bazel_vb/a41a00c949dc2b3a22fd05f82d8c05c2/external/rules_cc/temp15386256763950372734/master.zip: GET returned 404 Not Found
ERROR: Analysis of target '//mediapipe/examples/desktop/hello_world:hello_world' failed; build aborted: com.google.devtools.build.lib.packages.RepositoryFetchException: no such package '@rules_cc//cc': java.io.IOException: Error downloading [https://github.com/bazelbuild/rules_cc/archive/master.zip] to /home/vb/.cache/bazel/_bazel_vb/a41a00c949dc2b3a22fd05f82d8c05c2/external/rules_cc/temp15386256763950372734/master.zip: GET returned 404 Not Found

@aiuto
Copy link
Contributor

aiuto commented Jun 28, 2021

Yes. You would have to change that to main.zip.

But... I think that is the wrong solution as well. You should not build your projects against the head of any dependencies. Doing that gives control over what goes into your project to someone else. The best thing to do is reference a named release. Unfortunately there are none, #91 Without that, freezing to a commit that you have tested against is the next best fallback.

@aiuto aiuto reopened this Jun 28, 2021
@viblo
Copy link

viblo commented Jun 29, 2021

Seems like they fixed it now: google-ai-edge/mediapipe@374f5e2

@KennethHarmon KennethHarmon mentioned this issue Jul 1, 2021
Closed
KennethHarmon added a commit to KennethHarmon/MediaPipeUnityPlugin that referenced this issue Jul 1, 2021
@KennethHarmon
Updated WORKSPACE file
438b7e6 
Changed url and prefix for c++ rules to reflect renaming of branch as seen here: bazelbuild/rules_cc#107
@KennethHarmon KennethHarmon mentioned this issue Jul 1, 2021
Merged
copybara-service bot pushed a commit to google/XNNPACK that referenced this issue Jul 1, 2021
@xnnpack-bot
Update reference to rules_cc to main.zip. This is required by bazelbu…
5927478 
…ild/rules_cc#107

The longer term solution is:
- To use a named release of rules_cc once that is available (See bazelbuild/rules_cc#91)
- Wrap the `http_archive` rules with `maybe` so that there will not be conflicts if downstream users try to mix rules_cc versions.

PiperOrigin-RevId: 382526074
@copybara-service copybara-service bot mentioned this issue Jul 1, 2021
Merged
copybara-service bot pushed a commit to google/XNNPACK that referenced this issue Jul 1, 2021
@xnnpack-bot
Update reference to rules_cc to main.zip. This is required by bazelbu…
7c1e02c 
…ild/rules_cc#107

The longer term solution is:
- To use a named release of rules_cc once that is available (See bazelbuild/rules_cc#91)
- Wrap the `http_archive` rules with `maybe` so that there will not be conflicts if downstream users try to mix rules_cc versions.

PiperOrigin-RevId: 382526074
@ChrisReinke ChrisReinke mentioned this issue Jul 1, 2021
Closed
copybara-service bot pushed a commit to google/XNNPACK that referenced this issue Jul 1, 2021
@xnnpack-bot
Update reference to rules_cc to main.zip. This is required by bazelbu…
1514774 
…ild/rules_cc#107

The longer term solution is:
- To use a named release of rules_cc once that is available (See bazelbuild/rules_cc#91)
- Wrap the `http_archive` rules with `maybe` so that there will not be conflicts if downstream users try to mix rules_cc versions.

PiperOrigin-RevId: 382526074
copybara-service bot pushed a commit to google/XNNPACK that referenced this issue Jul 1, 2021
@xnnpack-bot
Update reference to rules_cc to main.zip. This is required by bazelbu…
e1c7fed 
…ild/rules_cc#107

The longer term solution is:
- To use a named release of rules_cc once that is available (See bazelbuild/rules_cc#91)
- Wrap the `http_archive` rules with `maybe` so that there will not be conflicts if downstream users try to mix rules_cc versions.

PiperOrigin-RevId: 382531776
copybara-service bot pushed a commit to google/XNNPACK that referenced this issue Jul 1, 2021
@xnnpack-bot
Update reference to rules_cc to main.zip. This is required by bazelbu…
78f98c1 
…ild/rules_cc#107

The longer term solution is:
- To use a named release of rules_cc once that is available (See bazelbuild/rules_cc#91)
- Wrap the `http_archive` rules with `maybe` so that there will not be conflicts if downstream users try to mix rules_cc versions.

PiperOrigin-RevId: 382544881
@copybara-service copybara-service bot mentioned this issue Jul 1, 2021
Merged
copybara-service bot pushed a commit to google/XNNPACK that referenced this issue Jul 1, 2021
@xnnpack-bot
Update reference to rules_cc to main.zip. This is required by bazelbu…
8eca65f 
…ild/rules_cc#107

The longer term solution is:
- To use a named release of rules_cc once that is available (See bazelbuild/rules_cc#91)
- Wrap the `http_archive` rules with `maybe` so that there will not be conflicts if downstream users try to mix rules_cc versions.

PiperOrigin-RevId: 382544881
copybara-service bot pushed a commit to google/XNNPACK that referenced this issue Jul 1, 2021
@xnnpack-bot
Update reference to rules_cc to main.zip. This is required by bazelbu…
366a6a5 
…ild/rules_cc#107

The longer term solution is:
- To use a named release of rules_cc once that is available (See bazelbuild/rules_cc#91)
- Wrap the `http_archive` rules with `maybe` so that there will not be conflicts if downstream users try to mix rules_cc versions.

PiperOrigin-RevId: 382544881
copybara-service bot pushed a commit to google/XNNPACK that referenced this issue Jul 1, 2021
@xnnpack-bot
Update reference to rules_cc to main.zip. This is required by bazelbu…
d2527c2 
…ild/rules_cc#107

The longer term solution is:
- To use a named release of rules_cc once that is available (See bazelbuild/rules_cc#91)
- Wrap the `http_archive` rules with `maybe` so that there will not be conflicts if downstream users try to mix rules_cc versions.

PiperOrigin-RevId: 382555074
homuler pushed a commit to homuler/MediaPipeUnityPlugin that referenced this issue Jul 3, 2021
@KennethHarmon
fix: rules_cc's branch name (#211)
24576ce 
Changed url and prefix for c++ rules to reflect renaming of branch as seen here: bazelbuild/rules_cc#107
fenollp added a commit to fenollp/mediapipe-desktop-linux-demos that referenced this issue Jul 6, 2021
@fenollp
Work around bazelbuild/rules_cc#107
3118c72 
Signed-off-by: Pierre Fenoll <[email protected]>
@banditbandito banditbandito mentioned this issue Jul 30, 2021
Closed
alibros pushed a commit to alibros/mediapipe-unity that referenced this issue Sep 20, 2021
@KennethHarmon
fix: rules_cc's branch name (#211)
120a131 
Changed url and prefix for c++ rules to reflect renaming of branch as seen here: bazelbuild/rules_cc#107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aiuto aiuto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hlopko @viblo @aiuto