remove platform_mappings, again #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
approved these changes
Dec 5, 2024
aaronsky
requested review from
BalestraPatrick,
brentleyjones,
luispadron,
mattrobmattrob and
thii
as code owners
luispadron
approved these changes
Dec 6, 2024
now that Bazel 6 isn't supported anymore, this should be okay. "should" is doing some heavy-lifting there, though, so let's run it through CI
aaronsky
force-pushed
the
aaronsky/remove-platform_mappings-bazel-6
branch
from
d263a8a to
0d249f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that Bazel 6 isn't supported anymore, this should be okay. "should"
is doing some heavy-lifting there, though, so let's run it through CI