Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the hmaptool support response file #2601

Conversation

qyang-nj
Copy link
Contributor

@qyang-nj qyang-nj commented Nov 18, 2024

Currently if we have a long list of header files for header_map rule

header_map(
  name = "HeaderMap",
  hdrs = [<A long list of header files],
)

we will see the following build error:

tools_hmaptool_BinaryHeaderMapTool/BinaryHeaderMapTool.swift:45: Fatal error: Missing output path

This is because Bazel will use response file for a long list of parameters (here). This PR makes hmaptool to support the response file and avoid the build error.

Copy link

google-cla bot commented Nov 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@brentleyjones brentleyjones merged commit 02c6aaa into bazelbuild:master Nov 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants