Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont override destination-timeout in xctestrun runner #2572

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Dont override destination-timeout in xctestrun runner #2572

merged 1 commit into from
Oct 29, 2024

Conversation

luispadron
Copy link
Contributor

The default value for this is 30. We probably shouldn't override this by default. I will follow up this PR by allowing the -destination-timeout to be set via the ios_xctestrun_runner rule and via the --test_env

man xcodebuild

-destination-timeout timeout
  Use the specified timeout when searching for a destination device. The default is 30 seconds.

@luispadron luispadron marked this pull request as ready for review October 29, 2024 18:46
@brentleyjones brentleyjones merged commit fe9a83f into master Oct 29, 2024
10 checks passed
@brentleyjones brentleyjones deleted the luis/dont-set-destination-timeout branch October 29, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

@BalestraPatrick BalestraPatrick Awaiting requested review from BalestraPatrick BalestraPatrick is a code owner

@keith keith Awaiting requested review from keith keith is a code owner

@mattrobmattrob mattrobmattrob Awaiting requested review from mattrobmattrob mattrobmattrob is a code owner

@thii thii Awaiting requested review from thii thii is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luispadron @brentleyjones