Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apple_static_xcframework rule to exclude bundles of dependencies marked as avoid_deps #2541

Conversation

sewerynplazuk
Copy link
Contributor

@sewerynplazuk sewerynplazuk commented Sep 23, 2024

Fixes #2540.

Alternatively, I thought about not including resources from the dependencies passed in avoid_deps, but I'm not sure that this would not be a breaking change.

@brentleyjones
Copy link
Collaborator

Alternatively, I thought about not including resources from the dependencies passed in avoid_deps, but I'm not sure that this would not be a breaking change.

That seems like the right way to go? I'll wait for other opinions though.

@luispadron
Copy link
Contributor

Alternatively, I thought about not including resources from the dependencies passed in avoid_deps, but I'm not sure that this would not be a breaking change.

That seems like the right way to go? I'll wait for other opinions though.

When would we expect to use avoid_bundles but not avoid_deps? If its never, then we should just use avoid_deps for this imo

@sewerynplazuk sewerynplazuk changed the title Introduce avoid_bundles into apple_static_xcframework rule Fix apple_static_xcframework rule to exclude bundles of dependencies marked as avoid_deps Sep 24, 2024
@sewerynplazuk
Copy link
Contributor Author

@brentleyjones @luispadron Thanks guys for your input. As avoid_bundles would rather be used always together with avoid_deps I have updated the PR to rely on the latter instead.

@brentleyjones brentleyjones merged commit ab29ef8 into bazelbuild:master Sep 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apple_static_xcframework - resulting XCFramework contains dependencies bundles passed as avoid_deps
3 participants