Support Linux with dossier_codesigning_reader.py
#2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux there is no keychain or the `security` command. To codesign on Linux you’ll have to use something like https://gregoryszorc.com/docs/apple-codesign/0.17.0/apple_codesign_rcodesign.html, with a wrapper that translates `codesign` arguments to `rcodesign` arguments. Using that method requires using `.cer` files instead of identity strings (which are part of the subject of a certificate). The change made here assumes you are using that method, which has worked for us in our internal project. Signed-off-by: Brentley Jones <[email protected]>
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
Signed-off-by: Brentley Jones <[email protected]>
luispadron
approved these changes
Sep 25, 2024
brentleyjones
deleted the
bj/support-linux-with-dossier_codesigning_reader.py
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux there is no keychain or the
securitycommand. To codesign on Linux you’ll have to use something like https://gregoryszorc.com/docs/apple-codesign/0.17.0/apple_codesign_rcodesign.html, with a wrapper that translatescodesignarguments torcodesignarguments.Using that method requires using
.cerfiles instead of identity strings (which are part of the subject of a certificate). The change made here assumes you are using that method, which has worked for us in our internal project.