Flip --incompatible_objc_linking_info_migration back for now
#1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes our builds with `last_green` bazel. bazelbuild/bazel@7b4acfe
thii
force-pushed
the
thi/flip-incompatible_objc_linking_info_migration-back-for-now
branch
2 times, most recently
from
cd83173 to
03155cf
Compare
brentleyjones
referenced
this pull request
in bazelbuild/bazel
Jan 26, 2023
See #16939. This flips the default behavior so that builtin Objective C rules will get their linking info from CcInfo instead of ObjcProvider. We will start cleaning up apple/swift starlark rules to stop generating linking info in ObjcProvider, so it makes sense to flip the default for this flag before those changes land in open source. RELNOTES[inc]: builtin objc rules will get their linking info from CcInfo, not ObjcProvider PiperOrigin-RevId: 504621116 Change-Id: I78ab2d3aca85dc0c7ef754dc8240ffa6a8f66ab9
googlewalt
reviewed
Jan 26, 2023
thii
force-pushed
the
thi/flip-incompatible_objc_linking_info_migration-back-for-now
branch
from
03155cf to
cd83173
Compare
thii
requested review from
BalestraPatrick,
keith and
segiddins
as code owners
brentleyjones
approved these changes
Jan 26, 2023
thii
deleted the
thi/flip-incompatible_objc_linking_info_migration-back-for-now
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes our builds with
last_greenbazel.bazelbuild/bazel@7b4acfe