Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rules_apple fails on Bazel@HEAD in downstream CI. #1956

Closed
sgowroji opened this issue May 4, 2023 · 7 comments · Fixed by #1534
Closed

Rules_apple fails on Bazel@HEAD in downstream CI. #1956

sgowroji opened this issue May 4, 2023 · 7 comments · Fixed by #1534

Comments

@sgowroji
Copy link
Member

sgowroji commented May 4, 2023 •
edited
Loading

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2997#0187e486-336b-4f41-9a92-f6c60a3ce01d

Platform : rules_apple (Latest Bazel on :mac: (OpenJDK 11, Xcode))

Logs:

ERROR: /Users/buildkite/builds/bk-imacpro-17/bazel-downstream-projects/rules_apple/test/starlark_tests/rules/apple_verification_test.bzl:77:43: transition output '//command_line_option:apple_bitcode' does not correspond to a valid setting
--
  | (04:16:15) ERROR: /Users/buildkite/builds/bk-imacpro-17/bazel-downstream-projects/rules_apple/test/starlark_tests/BUILD:128:26: Errors encountered while applying Starlark transition
  | (04:16:15) ERROR: Analysis of target '//test/starlark_tests:tvos_unit_test_test_bundle_id_override' failed; build aborted:

Culprit : https://buildkite.com/bazel/culprit-finder/builds/5478#0187e628-15b5-4551-a37f-4229dfbd5afb

Steps Followed:

  1. git clone https://github.com/bazelbuild/rules_apple.git
  2. git reset 796fae6 --hard
  3. export USE_BAZEL_VERSION=8087520b153832656695fef6f3654ed432642c98
  4. bazel build tools/... test/...

CC @meteorcloudy
@sgowroji
Copy link
Member Author

sgowroji commented May 4, 2023

Seeing the same error on rules_swift

@meteorcloudy
Copy link
Member

Probably caused by bazelbuild/bazel@37b8e1b, /cc @keith

@meteorcloudy
Copy link
Member

Maybe https://github.com/bazel-contrib/bazel_features can help if you want to detect if this feature was removed or not.

@meteorcloudy meteorcloudy mentioned this issue May 4, 2023
Closed
@meteorcloudy
Copy link
Member

FYI @lberki @oquenchil

@keith
Copy link
Member

keith commented May 4, 2023

blocked on bazelbuild/bazel#18321

@keith keith mentioned this issue May 4, 2023
Merged
@meteorcloudy
Copy link
Member

After this is fixed, can you please also help address bazelbuild/examples#288 ?

keith added a commit that referenced this issue May 5, 2023
@keith
Remove bitcode support (#1534)
5b7c929 
Now that Xcode 14.1 is the minimum supported to the App Store, and Xcode
14.0 dropped support for bitcode, we don't need to handle these flags
anymore.

Closes #1956
@keith
Copy link
Member

keith commented May 5, 2023

bazelbuild/examples#289

@sgowroji sgowroji mentioned this issue May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove bitcode support bazelbuild/rules_apple
3 participants
@keith @meteorcloudy @sgowroji