Skip to content

Commit

Permalink
nit fix: remove extra newline
Browse files Browse the repository at this point in the history
  • Loading branch information
kastiglione committed Sep 6, 2019
1 parent fbac918 commit 8724fc4
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ ios_application(
bundle_id = "com.example.app",
families = ["iphone", "ipad"],
infoplists = [":Info.plist"],
minimum_os_version = "10.0",
deps = [":Lib"],
)
```
Expand Down
10 changes: 10 additions & 0 deletions apple/internal/rule_support.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,16 @@ _RULE_TYPE_DESCRIPTORS = {
requires_provisioning_profile = False,
skip_signing = True,
),
apple_product_type.bundle: _describe_rule_type(
allowed_device_families = ["iphone", "ipad"],
bundle_extension = ".bundle",
has_infoplist = True,
product_type = apple_product_type.bundle,
requires_bundle_id = True,
requires_provisioning_profile = False,
requires_signing_for_device = False,
skip_signing = True,
),
# ios_ui_test
apple_product_type.ui_test_bundle: _describe_rule_type(
allowed_device_families = ["iphone", "ipad"],
Expand Down
1 change: 0 additions & 1 deletion test/ios_framework_import_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ EOF
do_build ios //app:app || fail "Should build"
}


function test_swift_library_depends_on_dynamic_import() {
create_common_files

Expand Down

0 comments on commit 8724fc4

Please sign in to comment.