Support additional rule providers in make_rule #95
+135
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
commented
Jun 21, 2023
| @@ -29,22 +29,24 @@ def make_rule( | |||
| attrs = ATTRS, | |||
| implementation = impl, | |||
| provides = _DEFAULT_PROVIDES, | |||
| additional_toolchains = []): | |||
| additional_toolchains = [], | |||
| additional_providers = []): | |||
There was a problem hiding this comment.
Having the additional providers here is technically not needed. Happy to revert if it only makes sense supporting this at the android_library level for now.
Bencodes
changed the title
Bencodes
force-pushed
the
support-additional_providers-in-make_rule
branch
from
39e7010
to
40434d4
Compare
ahumesky
approved these changes
Sep 29, 2023
Bencodes
force-pushed
the
support-additional_providers-in-make_rule
branch
from
f579cb1
to
15e9507
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for additional providers when calling
make_ruleso that we can extendandroid_libraryrule inside ofrules_kotlinto also provideKtJvmInfo