Only add validation outputs to the _validation output_group #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the `--run_validations` flag is useless
|
cc @Bencodes |
ahumesky
reviewed
Sep 27, 2023
| @@ -555,7 +555,6 @@ def finalize( | |||
| ), | |||
| _direct_source_jars = depset([ctx.outputs.lib_src_jar]), | |||
| _hidden_top_level_INTERNAL_ = depset( | |||
| resources_ctx.validation_results, | |||
There was a problem hiding this comment.
Should these be added to validation_outputs below, or are these already included? I looked through the code and I'm not sure that they're already there, but maybe I missed it
| @@ -592,7 +592,6 @@ def impl(ctx): | |||
| # Bazel developers so that `bazel build java/com/my_aar_import` will fail if the resource | |||
| # processing or JAR merging steps fail. | |||
| files_to_build = [] | |||
| files_to_build.extend(resources_ctx.validation_results) # TODO(djwhang): This should be validation. | |||
There was a problem hiding this comment.
Should these be added to validation_outputs above, or are these already included? I looked through the code and I'm not sure that they're already there, but maybe I missed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the
--run_validationsflag is useless