Increase R8 allowed max memory usage #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen this action OOM a few times in our codebase. The default `4g` max set by `java.bzl` probably isn't going to be enough for R8 to successfully dex, desugar, and optimize a large application. Increasing the max allowed memory should be a safe change since R8 is one of the final actions in an apps build graph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen this action OOM a few times in our codebase. The default
4gmax set byjava.bzlprobably isn't going to be enough for R8 to successfully dex, desugar, and optimize a large application.Increasing the max allowed memory should be a safe change since R8 is one of the final actions in an apps build graph.