Add LogStream #148
Merged
Add LogStream #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the logstream API, originally pushed upstream by Eric Burnett to https://gist.github.com/EricBurnett/a094e0b8474b834d098e86bf20fa202b via https://groups.google.com/g/remote-execution-apis/c/LCLsBSgSnU0/m/yTTtqr-cAwAJ Update to include a copyright notice; set the version number to v1 and update the package to reflect the location within the remote-apis repo. Signed-off-by: Ed Baunton <[email protected]>
edbaunton
requested review from
agoulti,
bergsieker,
buchgr and
ola-rozenfeld
as code owners
googlebot
added
the
cla: yes
sstriker
approved these changes
Jul 14, 2020
EricBurnett
previously requested changes
Jul 16, 2020
| // A handle to a log (an ordered sequence of bytes). | ||
| message LogStream { | ||
| // Structured name of the resource in the format: | ||
| // {parent=**}/logStreams/{logstream_id} |
There was a problem hiding this comment.
Let's correct this while we're here: logStreams -> logstreams. (Resources are usually lowercase, and this is already wrong with having a lowercase l and uppercase S)
There was a problem hiding this comment.
Couple more: lines 114, 120, and 121 also thanks!
There was a problem hiding this comment.
Ah good catch! Should be fixed now.
EricBurnett
approved these changes
Aug 6, 2020
Add a BUILD file and build the remote_logstream.pb.go component. Add that to the pre-commit script. Update remote_logstream.proto to include packaging information for the various programming languages it can be used from, copying the style from asset. Lowercase the resource name from "logStreams" to "logstreams" for consistency. Signed-off-by: Ed Baunton <[email protected]>
santigl
pushed a commit
to santigl/remote-apis
that referenced
this pull request
Aug 26, 2020
…resolve to physical inputs (bazelbuild#148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the logstream API, originally pushed upstream by Eric Burnett to
gist.github.com/EricBurnett/a094e0b8474b834d098e86bf20fa202b via
groups.google.com/g/remote-execution-apis/c/LCLsBSgSnU0/m/yTTtqr-cAwAJ
Update to include a copyright notice; set the version number to v1 and update
the package to reflect the location within the remote-apis repo.
I made no material changes to the logstream api other than:
remote_logstream.proto.