Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common i386 alias #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bivens-dev
Copy link

Wanted to ask if you would be open to something like this? I saw some precedent in the file but wasn't sure if this was a pattern you wanted to avoid potentially.

I ran into this writing a new rule set and was running into writing a bunch of additional logic that could have just been avoided with an alias like this so I figured I would submit it as a pull request and see what y'all think :)

@aiuto
Copy link
Contributor

aiuto commented Feb 9, 2023

How does this avoid additional logic?
Adding aliases gives a single concept two names, which is usually a path to future confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants