Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wasm cpu #12

Merged
merged 1 commit into from
Jun 3, 2020
Merged

add wasm cpu #12

merged 1 commit into from
Jun 3, 2020

Conversation

lizan
Copy link
Contributor

@lizan lizan commented May 1, 2020

Signed-off-by: Lizan Zhou [email protected]

Signed-off-by: Lizan Zhou <[email protected]>
@katre katre requested review from katre and gregestren May 1, 2020 22:00
@katre
Copy link
Member

katre commented May 4, 2020

Is wasm a CPU architecture? How is it intended to be used?

@gregestren
Copy link
Collaborator

@lizan can you speak more to the concerns expressed in https://github.com/bazelbuild/platforms#adding-a-canonical-constraint-value?

I realize we still need to evolve the process. It's not immediately obvious what belongs in this repo vs. not, and we need clearer agreement on how to even have the right discussions to figure that out.

But the link above is at least a starting point. This is important not just for us (reviewers and PR producer), but anyone else who may ever look at or consider using these.

@lizan
Copy link
Contributor Author

lizan commented May 5, 2020

@katre yes it should be treated as a CPU architecture. Go/Rust and LLVM treat it as an arch.

@gregestren Sure, the wasm32 already defined in rules_rust, 64bit is a future feature so if we don't like, I can remove that. I am working on make this build in proxy-wasm and Envoy WASM integration, this uses cpu value wasm. The bazel C++ Toolchain blog uses asmjs which is quite confusing as well. There should be a canonical constraint settings for this instead of having CPU value defined everywhere.

@lizan
Copy link
Contributor Author

lizan commented May 26, 2020

gently ping?

@katre
Copy link
Member

katre commented Jun 3, 2020

Looking today, sorry again for the delays.

@katre
Copy link
Member

katre commented Jun 3, 2020

Working to merge this now!

@bazel-io bazel-io merged commit 681f1ee into bazelbuild:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants