Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qsync): Enable basic syntax highlighting in 'analysis disabled' mode #6941

Merged

Conversation

tpasternak
Copy link
Collaborator

@tpasternak tpasternak commented Oct 29, 2024

Before:

Screenshot 2024-10-29 at 17 36 26

After

Screenshot 2024-10-29 at 16 44 22

@tpasternak tpasternak marked this pull request as ready for review October 29, 2024 16:36
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Oct 29, 2024
@@ -409,6 +410,9 @@
<registryKey defaultValue="true"
description="Causes the plugin to read external workspace data, enabling features such as code completion for external targets. This may incur the cost of an additional 'bazel mod' call, which could cause issues with older versions or setups."
key="bazel.read.external.workspace.data"/>
<registryKey defaultValue="true"
description="Enable basic syntax highliting in Query Sync's 'Analysis Disabled' mode"
key="bazel.qsync.enable.basic.highlighting.when.analysis.disabled"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For flags trailing .disabled can be confusing... Usually it is attributed to flag default state.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right!

@tpasternak tpasternak merged commit 13b1799 into bazelbuild:master Oct 29, 2024
6 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Oct 29, 2024
@tpasternak tpasternak deleted the enable-syntax-highlighting-in-qsync branch October 29, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

5 participants