CLion Virtual Include Fixes #6759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeFrosch
force-pushed
the
virtual-includes-fix
branch
from
587a606
to
ec39b56
Compare
LeFrosch
requested review from
mai93,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: CLion
|
Is there an ETA to this pull-request changes? |
I'll check it this week |
|
@LeFrosch I almost understand the whole change, but let's have a chat on Monday as the PR description is too concise imo. I've also noticed it does not work with bzlmod (but I believe the original code didn't work either), so maybe consider this as a next step (or improve here?) |
ujohnny
requested changes
Sep 25, 2024
base/src/com/google/idea/blaze/base/sync/workspace/VirtualIncludesHandler.java
Outdated
Show resolved
Hide resolved
ujohnny
approved these changes
Sep 30, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses problems with the virtual includes handler:
Also removes the
-ibazelsupport and adds integration tests.