-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extension point to detect whether a module is to be orphaned or retained. #6467
Add extension point to detect whether a module is to be orphaned or retained. #6467
Conversation
base/src/com/google/idea/blaze/base/sync/projectstructure/OrphanedModuleValidator.java
Outdated
Show resolved
Hide resolved
base/src/com/google/idea/blaze/base/sync/projectstructure/ModuleEditorImpl.java
Outdated
Show resolved
Hide resolved
base/src/com/google/idea/blaze/base/sync/projectstructure/ModuleEditorImpl.java
Outdated
Show resolved
Hide resolved
base/src/com/google/idea/blaze/base/sync/projectstructure/ModuleValidator.java
Outdated
Show resolved
Hide resolved
base/src/com/google/idea/blaze/base/sync/projectstructure/ModuleEditorImpl.java
Outdated
Show resolved
Hide resolved
base/src/com/google/idea/blaze/base/sync/projectstructure/ModuleEditorImpl.java
Outdated
Show resolved
Hide resolved
base/src/com/google/idea/blaze/base/sync/projectstructure/ModuleValidator.java
Outdated
Show resolved
Hide resolved
c220215
to
c9d51b0
Compare
ExtensionPointName<ExternalModuleProvider> EP_NAME = | ||
ExtensionPointName.create("com.google.idea.blaze.base.sync.projectstructure.ExternalModuleProvider"); | ||
|
||
boolean isOwnedByExternalModule(Module module); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not really externalModule
that own this module but it is much better than validation
so I'll approve (not that it matters :) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, if it was an internal name I would change it afterwards, but this is an EP, so let's avoid changes once its merged. Could you please change that to isOwnedByExternalPlugin
or isOwnedByThirdPartyPlugin
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to 'isOwnedByExternalPlugin'. Please a take @tpasternak.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ExtensionPointName<ExternalModuleProvider> EP_NAME = | ||
ExtensionPointName.create("com.google.idea.blaze.base.sync.projectstructure.ExternalModuleProvider"); | ||
|
||
boolean isOwnedByExternalModule(Module module); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, if it was an internal name I would change it afterwards, but this is an EP, so let's avoid changes once its merged. Could you please change that to isOwnedByExternalPlugin
or isOwnedByThirdPartyPlugin
?
e9f7069
to
b899b34
Compare
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>
Description of this change
Added an EP to give the feasibility to allow other modules. For example, when maven modules are added into project view bazel sync resets the view as they have different content root. An implementation could be added to allow maven modules to be shown in project tree view.