Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Pass --override_repository flag to all commands for faster analysis phase #6453

Merged

Conversation

tpasternak
Copy link
Collaborator

@tpasternak tpasternak commented May 31, 2024

Using this flag ensures consistency across commands and prevents large portions of the Skyframe cache from being evicted. This avoids longer analysis phases. To experiment, view the cache summary with bazel dump --skyframe=summary.

@tpasternak tpasternak requested a review from ujohnny May 31, 2024 13:18
Using this flag ensures consistency across commands and prevents large portions
of the Skyframe cache from being evicted. This avoids longer analysis phases.
To experiment, view the cache summary with `bazel dump --skyframe=summary`.
@tpasternak tpasternak force-pushed the pass-override-repository-to-all-commands branch from 290f104 to f7511d4 Compare May 31, 2024 13:43
@tpasternak tpasternak changed the title perf: Pass --override_repository flag to all commands for faster anal… perf: Pass --override_repository flag to all commands for faster analysis phase May 31, 2024
@tpasternak tpasternak marked this pull request as ready for review May 31, 2024 14:39
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels May 31, 2024
@tpasternak tpasternak assigned tpasternak and mai93 and unassigned mai93 May 31, 2024
@mai93 mai93 merged commit cde116d into bazelbuild:master May 31, 2024
8 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label May 31, 2024
gchandu25 pushed a commit to gchandu25/bazelbuild-intellij that referenced this pull request Jun 7, 2024
…ysis phase (bazelbuild#6453)

* Pass --override_repository flag to all commands run from the plugin.

Using this flag ensures consistency across commands and prevents large portions
of the Skyframe cache from being evicted. This avoids longer analysis phases.
To experiment, view the cache summary with `bazel dump --skyframe=summary`.

* Fix android studio tests

* Fix AS tests

* Missing semicolon

* Remove unused method "getAspectFlags()"

* Convert to optional
@tpasternak tpasternak deleted the pass-override-repository-to-all-commands branch August 8, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants