Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JetBrains IDEs 2024.2 #6434

Merged
merged 11 commits into from
Jun 3, 2024
Merged

Support JetBrains IDEs 2024.2 #6434

merged 11 commits into from
Jun 3, 2024

Conversation

tpasternak
Copy link
Collaborator

@tpasternak tpasternak commented May 17, 2024

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

Noticable changes:

  1. I had to add direct dependency on "@io_grpc_grpc_java//api" in //ext:intellijext because the classes are not inside intellij any more. Still, the api classes were dependencies, but just transitive ones.
  2. Intellij moved some class files from lib/.jar to lib/modules/.jar for Java plugin and for Core. I had to include them in intellij_platform_sdk
  3. [EAP2] Changes in Python plugin jar directories strucutre
  4. [EAP2] New method in TypeScriptConfig interface
  5. [EAP2] Some tests now require ExperimentalUI service to be set, so they had to be moved to integration tests suite
  6. [EAP2] new layout of go plugin jars directories

most of the files are just copies, you can compare them with this script:

diff -r sdkcompat/v2{41,42}
diff -r cpp/sdkcompat/v2{41,42}
diff -r testing/testcompat/v2{41,42}
diff intellij_platform_sdk/BUILD.idea2{41,42}
diff intellij_platform_sdk/BUILD.ue2{41,42}
diff intellij_platform_sdk/BUILD.clion2{41,42}

@tpasternak tpasternak marked this pull request as ready for review May 31, 2024 11:08
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels May 31, 2024
@mai93 mai93 merged commit caebaca into bazelbuild:master Jun 3, 2024
8 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Jun 3, 2024
@LeFrosch LeFrosch mentioned this pull request Jun 6, 2024
3 tasks
gchandu25 pushed a commit to gchandu25/bazelbuild-intellij that referenced this pull request Jun 7, 2024
* Support JetBrains IDEs 2024.2

* Fix tests include missing libraries from modules

* Support CE

* Add direct dependency in grpc-api. The library was always there, but it was an indirect dependency of ext

* Comment out clion section as it is not released yet

* Set correct toml plugin url

* EAP 2

* Move tests requiring isNewUI call from unit tests to integration tests.

They need ExperimentaUI service to be set

https://sourcegraph.com/github.com/JetBrains/intellij-community/-/commit/a22187eb5f46e44e2c283bbae6e2854e0d8e97ee#diff-6771702fd993518904c93eab88375c67R44
https://sourcegraph.com/github.com/JetBrains/intellij-community/-/commit/3f90c0e90f21f5977c945c845169e29346307615#diff-6771702fd993518904c93eab88375c67L40

* Enbale plugin_dev integration tests

* New jar directory layout in Go Plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants