Prioritize scala and kt providers before JavaInfo #1202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
closed this
in
|
Thanks! What I don’t understand is what is missing from the JavaInfo rules_scala generates? The scala attribute is more brittle than the canonical JavaInfo provider |
|
Or is it just about having some sort of “signal” to the plugin that this is scala core? |
|
It's an actual difference between target[JavaInfo] and target.scala. We treat them identically otherwise. The aspect otherwise doesn't distinguish between java and scala targets, and the plugin only uses the rule kind to distinguish between them. |
|
Wow. That’s bad. Sounds like on rules_scala side. I’ll run the aspect and try to print debug the differences between the two. Thanks! |
aradchykov
pushed a commit
to aradchykov/intellij
that referenced
this pull request
Oct 6, 2019
…j PR import bazelbuild#1202) While `scala_library` / other Scala rules have `JavaInfo` as well, their Scala-specific data lives in the `scala` provider. Proritizing `JavaInfo` over `scala` causes the plugin to assume that there are no outputs, hence causing all Scala workspaces to fail to resolve ("No Scala SDK added") bazelbuild#1183 Instead, prioritize `kt` and `scala` providers over `JavaInfo`. This wasn't an issue previously because we c[hecked for the legacy "java" provider first](bazelbuild@5f03bde), which Scala targets do not have, and the conditional successfully fell through. This fixes bazelbuild#1183. Closes bazelbuild#1202 PiperOrigin-RevId: 271236868
comius
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
scala_library/ other Scala rules haveJavaInfoas well, their Scala-specific data lives in thescalaprovider. ProritizingJavaInfooverscalacauses the plugin to assume that there are no outputs, hence causing all Scala workspaces to fail to resolve ("No Scala SDK added") #1183Instead, prioritize
ktandscalaproviders overJavaInfo.This wasn't an issue previously because we checked for the legacy "java" provider first, which Scala targets do not have, and the conditional successfully fell through.
This fixes #1183.