-
Notifications
You must be signed in to change notification settings - Fork 35
Add support for release candidates #11
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it!
|
CLAs look good, thanks! |
Is the build failure related to my pull request? If there's something I should change let me know. |
Hi @kkiningh, thanks, that looks pretty good! Don't worry about the test - I think our current Travis setup is a bit broken. I'll ping this PR when it should work again, so we can rerun the tests on this one (although I don't see any issues). |
@kkiningh Sorry for the delay in merging :( Would you mind rebasing your PR? I'll merge it then! Otherwise I could also just apply your proposed changes to the current file myself (but then it wouldn't be in your name, so I wanted to check). Let me know. :) |
Feel free to apply the changes yourself! I'm on vacation and won't be able to get to it until after Christmas. |
Resolves issue #10. Might want to refactor a tiny bit so that upgrading the release candidate means only changing the version string and not the url.